docs: fix layer-spec drift in 001/007/010 (pager, VFS, VDBE-write) - #617
Merged
Conversation
Audited the remaining specs not covered by the prior spec-drift pass (#609): pager, value-semantics, VDBE codegen/write, analyze-cost-model, VFS, and btree. - 001-architecture: VFS trait/File trait code blocks were fictional (wrong method names/signatures) — replaced with the real src/vfs.rs Vfs/VfsFile surface. - 006-btree: Req 4's rowid-alias test link was marked "(planned)" even though rowid_alias_from_sql/with_computed_rowid_alias landed and are exercised by tests/unit/codegen_insert_test.rs. - 007-pager: added Requirement 7 for PASSIVE WAL checkpointing (src/pager/checkpoint.rs, #386, ADR-0025), which had zero spec traceability despite being landed, tested functionality. - 010-vdbe-write-opcodes: the tier2 UPDATE stub was described as still future/#[ignore]d; #217 already flipped it. 008-value-semantics, 009-vdbe-codegen, and 011-analyze-cost-model audited clean, no changes needed. make assurance: 82/82 requirements, 263/263 scenarios, no dead links. spend: ~5 audit forks + fixes, roughly matches an ad-hoc chore budget Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit of the layers not covered by the prior spec-drift pass (#609: specs 001/002/003/005/006). This one covers pager, value-semantics, VDBE codegen/write, analyze-cost-model, VFS, and btree.
Changes
Filetrait code blocks were fictional (wrong method names/signatures) — replaced with the realVfs/VfsFilesurface fromsrc/vfs.rs.src/pager/checkpoint.rs, pager: PASSIVE checkpoint #386, ADR-0025), which had landed, tested functionality but zero spec traceability.UPDATEstub as still future/#[ignore]d — V3 exit gate: 0.12.0 release #217 already flipped it.006-btree's Req 4 drift (stale "(planned)" test link) was independently fixed and merged via #614 while this branch was in flight — this PR rebases past that and keeps main's (more complete) version rather than reintroducing a redundant edit.
008-value-semantics, 009-vdbe-codegen, and 011-analyze-cost-model were audited and found clean — no changes needed there.
Testing
make assurance: 83/83 requirements, 266/266 scenarios, no dead linkscargo fmt --check/cargo clippy -D warningspass (pre-push hook)Token spend
Ad-hoc chore (audit + fix), not a ticketed issue — no complexity estimate to match against. ~5 parallel audit forks plus targeted fixes.